Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(devtools-proxy-support): remove certificates without issuer from system CA list COMPASS-8252 #467

Merged
merged 2 commits into from
Sep 5, 2024
Merged

fix(devtools-proxy-support): remove certificates without issuer from system CA list COMPASS-8252 #467

merged 2 commits into from
Sep 5, 2024

Commits on Sep 5, 2024

  1. fix(devtools-proxy-support): remove certificates without issuer from … 

    …system CA list COMPASS-8252

We have discovered that system certificate stores may contain certificates
that a) OpenSSL may choose over other roots for the same certificate chain
and b) are not accompanied by their own root certificate, i.e. only present
an immediate certificate.

While we will ideally solve this by using `X509_V_FLAG_PARTIAL_CHAIN`,
Node.js does not expose that as a feature yet.
    @addaleax
    addaleax committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a791a96 View commit details
    Browse the repository at this point in the history

  2. fixup: store final result of computation in cache

    @addaleax
    addaleax committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    4b60c71 View commit details
    Browse the repository at this point in the history