fix(build): make addon buildable as static library (#119)

Require libcom_err when building a static library because the code accesses `error_message()` which comes from it. Use `-l` prefix for included libs for Windows
mongodb-js · Apr 6, 2021 · 786e7d8 · 786e7d8
1 parent 880ae2e
commit 786e7d8
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/binding.gyp b/binding.gyp
@@ -2,6 +2,7 @@
   'targets': [
     {
       'target_name': 'kerberos',
+      'type': 'loadable_module',
       'include_dirs': [ '<!(node -e "require(\'nan\')")' ],
       'sources': [
         'src/kerberos.cc'
@@ -25,7 +26,16 @@
               '-lkrb5',
               '-lgssapi_krb5'
             ]
-          }
+          },
+          'conditions': [
+            ['_type=="static_library"', {
+              'link_settings': {
+                'libraries': [
+                  '-lcom_err'
+                ]
+              }
+            }]
+          ]
         }],
         ['OS=="win"',  {
           'sources': [
@@ -34,9 +44,9 @@
           ],
           'link_settings': {
             'libraries': [
-              'crypt32.lib',
-              'secur32.lib',
-              'Shlwapi.lib'
+              '-lcrypt32',
+              '-lsecur32',
+              '-lShlwapi'
             ]
           }
         }]