feat(cli-repl): add configuration to enable log compression MONGOSH-1986 #2362
+64
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
changed the title
gagik
force-pushed
the
gagik/add-log-compression
branch
from
f1163e0 to
d2b37ec
Compare
gagik
changed the title
gagik
force-pushed
the
gagik/add-log-compression
branch
from
d2b37ec to
7a95ddb
Compare
gagik
commented
Feb 10, 2025
| @@ -325,6 +325,7 @@ describe('CliRepl', function () { | |||
| 'logLocation', | |||
| 'logRetentionDays', | |||
| 'logMaxFileCount', | |||
| 'logCompressionEnabled', | |||
There was a problem hiding this comment.
could naming this enableLogCompression be more consistent with disableGreetingMessage, disableLogging, enableTelemetry?
There was a problem hiding this comment.
We've had this conversation in the tech design and decided that we'd go for disableXYZ/enableXYZ only for the top-level features, but use the xyzDetailedOption for the detailed configuration of each individual feature
addaleax
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
logCompressionEnabledoption and tests.