chore: replace jest with mocha VSCODE-516 #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
reviewed
Jan 18, 2024
Anemy
changed the title
|
Updated the tests to all run and the config to pass. This did increase the bundle size by ~2MB though which is substantial (do not merge). |
Slightly unrelated, noticed we're bundling a ton of frontend deps in the main extension bundle we don't need. Created https://jira.mongodb.org/browse/COMPASS-8154 for that. |
|
Looks like merging from main fixed it. Should be good to go now. |
addaleax
approved these changes
Aug 12, 2024
| @@ -1076,6 +1076,7 @@ | |||
| } | |||
| }, | |||
| "dependencies": { | |||
| "@babel/core": "^7.24.6", | |||
There was a problem hiding this comment.
Do we use this dependency somewhere?
| @@ -12,9 +13,10 @@ const connectionFormTestId = 'connection-form-modal'; | |||
| describe('OverviewPage test suite', function () { | |||
| afterEach(() => { | |||
| cleanup(); | |||
| Sinon.restore(); | |||
| sinon.restore(); | |||
There was a problem hiding this comment.
nit: I think everywhere in codebase, we stick to sandbox. e.g. sandbox.restore(), sandbox.spy().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes