-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace jest with mocha VSCODE-516 #668
Conversation
Updated the tests to all run and the config to pass. This did increase the bundle size by ~2MB though which is substantial (do not merge). |
Slightly unrelated, noticed we're bundling a ton of frontend deps in the main extension bundle we don't need. Created https://jira.mongodb.org/browse/COMPASS-8154 for that. |
Looks like merging from main fixed it. Should be good to go now. |
@@ -1076,6 +1076,7 @@ | |||
} | |||
}, | |||
"dependencies": { | |||
"@babel/core": "^7.24.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use this dependency somewhere?
@@ -12,9 +13,10 @@ const connectionFormTestId = 'connection-form-modal'; | |||
describe('OverviewPage test suite', function () { | |||
afterEach(() => { | |||
cleanup(); | |||
Sinon.restore(); | |||
sinon.restore(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think everywhere in codebase, we stick to sandbox. e.g. sandbox.restore()
, sandbox.spy()
.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes