Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-35302): C++: Add new sync control methods #3148

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

dacharyc
Copy link
Collaborator

@dacharyc dacharyc commented Jan 8, 2024

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-35302

  • Quick Start: Regenerate the "Open a Synced Realm" example without the sync session initialization and method call.
  • Sync/Manage Sync Sessions: Add new sync control methods for C++ v1.0.0.

Reminder Checklist

Before merging your PR, make sure to check a few things.

  • Did you tag pages appropriately?
    • genre
    • meta.keywords
    • meta.description
  • Describe your PR's changes in the Release Notes section
  • Create a Jira ticket for related docs-app-services work, if any

Release Notes

  • C++ SDK
    • Quick Start: Remove sync session initialization and method call from the "Open a Synced Realm" example.
    • Sync/Manage Sync Sessions: Add new sync control methods for C++ v1.0.0.

Review Guidelines

REVIEWING.md

Copy link

github-actions bot commented Jan 8, 2024

Readability for Commit Hash: a51b724

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/cpp/quick-start: Grade Level: 7.0, Reading Ease: 67.25
  • source/sdk/cpp/sync/manage-sync-session: Grade Level: 8.5, Reading Ease: 57.87

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

Copy link
Collaborator

@cbullinger cbullinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm!

source/sdk/cpp/sync/manage-sync-session.txt Outdated Show resolved Hide resolved
source/sdk/cpp/sync/manage-sync-session.txt Outdated Show resolved Hide resolved
source/sdk/cpp/sync/manage-sync-session.txt Outdated Show resolved Hide resolved
source/sdk/cpp/sync/manage-sync-session.txt Show resolved Hide resolved
source/sdk/cpp/sync/manage-sync-session.txt Outdated Show resolved Hide resolved
dacharyc and others added 2 commits January 9, 2024 09:03
Co-authored-by: cbullinger <115956901+cbullinger@users.noreply.github.com>
@dacharyc dacharyc merged commit 3c316d3 into mongodb:master Jan 9, 2024
6 checks passed
@dacharyc dacharyc deleted the DOCSP-35302 branch January 9, 2024 14:44
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants