Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-39539): Consolidate Stream Data to Atlas page #3268

Merged
merged 10 commits into from
May 24, 2024

Conversation

dacharyc
Copy link
Collaborator

@dacharyc dacharyc commented May 21, 2024

Pull Request Info - SDK Docs Consolidation

Jira ticket: https://jira.mongodb.org/browse/DOCSP-39539

Staged Page

Page Source

PR Author Checklist

Before requesting a review for your PR, please check these items:

  • Open the PR against the feature-consolidated-sdk-docs branch instead of master
  • Tag the consolidated page for:
    • genre
    • meta.keywords
    • meta.description

Naming

Links and Refs

  • Create new consolidated SDK ref targets starting with "_sdks-" for relevant sections
  • Remove or update any SDK-specific refs to use the new consolidated SDK ref targets
  • Update any Kotlin API links to use the new Kotlin SDK roles

Content

  • Shared code boxes have snippets or placeholders for all 9 languages
  • API description sections have API details or a generic placeholder for all 9 languages
  • Check related pages for relevant content to include
  • Create a ticket for missing examples in each relevant SDK: Consolidation Gaps epic

Reviewer Checklist

As a reviewer, please check these items:

  • Shared code example boxes contain language-specific snippets or placeholders for every language
  • API reference details contain working API reference links or generic content
  • Realm naming/language has been updated
  • All relevant content from individual SDK pages is present on the consolidated page

@dacharyc dacharyc added the merge to feature branch Unreleased feature - do not merge to Master label May 21, 2024
Copy link

github-actions bot commented May 21, 2024

Readability for Commit Hash: 178f5af

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/files/configure-and-open: Grade Level: 7.3, Reading Ease: 66.44
  • source/sdk/sync/stream-data-to-atlas: Grade Level: 9.9, Reading Ease: 48.91

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

dacharyc and others added 7 commits May 21, 2024 17:49
## Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-39161

- [Connect to App Services
Backend](https://preview-mongodblindseymoore.gatsbyjs.io/realm/DOCSP-39161/sdk/dotnet/app-services/connect-to-app-services-backend/)

- Note: Commented out failing tests. Fixing them will be a part of this
ticket: https://jira.mongodb.org/browse/DOCSP-39638.

### Reminder Checklist

Before merging your PR, make sure to check a few things.

- [ ] Did you tag pages appropriately?
  - genre
  - meta.keywords
  - meta.description
- [x] Describe your PR's changes in the Release Notes section
- [ ] Create a Jira ticket for related docs-app-services work, if any

### Release Notes

<!--
- **Kotlin** SDK
- Realm/Manage Realm Files/Encrypt a Realm: Add information on
encryption for
    local and synced realms.
-->

- .NET SDK
- Application Services/Connect to an App Services App: Add a section on
updating the base URL during runtime.

### Review Guidelines


[REVIEWING.md](https://github.com/mongodb/docs-realm/blob/master/REVIEWING.md)

---------

Co-authored-by: MongoCaleb <caleb.thompson@mongodb.com>
Copy link
Collaborator

@cbullinger cbullinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good 👍

database for Data Ingest, you *must* specify the ``asymmetric_object`` types
you want to sync.

.. tip:: Mixed Object and Asymmetric Object Types
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this really doesn't seem like a tip to me. I'd argue it should be incorporated into the above copy.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion about this. But I think it gets into subjective editorializing, which I don't think we necessarily have time to do as part of this project given the massive chunk of work that it represents. I think we should avoid rewriting/editing as much as possible, unless it's required to make the consolidated content work on the page.

.. tab::
:tabid: csharp

.. include:: /includes/dotnet-asymmetric-object.rst
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're going for consistency: this include doesn't have "For more information on how to define an asymmetric object, refer to Define an Asymmetric Object." link, like all the others do.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because it's an include that is also used on the data modeling page relative to asymmetric objects.

I guess I can remove it from here and just put a link out to the "define" page similar to the other SDKs.

- id: dart
content: |

.. literalinclude:: /examples/generated/flutter/open_flexible_sync_realm_test.snippet.open-flexible-sync-realm.dart
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this snippet references a Tricycle object in the schema instead of the WeatherSensor

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the snippet that's currently live on the page. I would guess it got updated and we didn't realize it was used in more than one place. I'll make a ticket in the Flutter Gaps epic to address this. 👍

source/sdk/sync/stream-data-to-atlas.txt Outdated Show resolved Hide resolved
source/sdk/sync/stream-data-to-atlas.txt Outdated Show resolved Hide resolved
source/sdk/sync/stream-data-to-atlas.txt Outdated Show resolved Hide resolved
source/sdk/sync/stream-data-to-atlas.txt Outdated Show resolved Hide resolved
@@ -0,0 +1,14 @@
Specify the ``AsymmetricObject`` types you want to sync.

.. note:: Mixed Synced and Non-Synced Databases in Projects
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any other restrictions in other SDKs re. mixing non- and asymmetric objects? or synced and non-synced dbs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I talked to engineering about it, it seemed like this was an issue specific to Swift and its use of reflection to infer realm/object schemas.

dacharyc and others added 2 commits May 24, 2024 17:12
Co-authored-by: cbullinger <115956901+cbullinger@users.noreply.github.com>
@dacharyc dacharyc merged commit a0659fc into mongodb:feature-consolidated-sdk-docs May 24, 2024
6 checks passed
@dacharyc dacharyc deleted the DOCSP-39539 branch May 24, 2024 21:37
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge to feature branch Unreleased feature - do not merge to Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants