-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-39527): Consolidate Custom User Data page #3346
(DOCSP-39527): Consolidate Custom User Data page #3346
Conversation
✅ Deploy Preview for device-sdk ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Readability for Commit Hash: 3201d61 You can see any previous Readability scores (if they exist) by looking Readability scores for changed documents:
For Grade Level, aim for 8 or below. For Reading Ease scores, aim for 60 or above:
For help improving readability, try Hemingway App. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a handful of minor suggestions. Thanks, @dacharyc!
data whenever a user refreshes their :ref:`access token | ||
<user-sessions>`, which is used by most SDK operations that contact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Know this content already existed, but the link here isn't obvious to me. We say "access token" and then send people to a User Sessions section that doesn't mention tokens at all. Would it make more sense to link directly to the Manage User Sessions page, which does talk about tokens?
source/includes/api-details/java/users/custom-user-data-read-custom-user-data-description.rst
Outdated
Show resolved
Hide resolved
source/includes/api-details/java/users/custom-user-data-read-custom-user-data-2-description.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Kyle Rollins <115574589+krollins-mdb@users.noreply.github.com>
6835ea9
into
mongodb:feature-consolidated-sdk-docs
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/realm/feature-consolidated-sdk-docs/ 🪵 Logs |
Pull Request Info - SDK Docs Consolidation
Jira ticket: https://jira.mongodb.org/browse/DOCSP-39527
Staged Page
Note for reviewer: a couple of the API descriptions are missing where we just don't have an example and there's nothing notable to say. I've added notes to the follow-up gap tickets to also fill in these API descriptions when we add examples.
Page Source
Add links to every SDK's pages where you got the SDK-specific information:
PR Author Checklist
Before requesting a review for your PR, please check these items:
feature-consolidated-sdk-docs
branch instead ofmaster
Naming
.rst
files comply with the naming guidelinesLinks and Refs
Content
Reviewer Checklist
As a reviewer, please check these items: