-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVPROD-13512: Disable task generation in Genny. #1284
base: master
Are you sure you want to change the base?
Conversation
We are switching over to using manually maintained files based in the DSI repo to run all Genny tasks. This removes any task generation functionality so that it doesn't cause confusion
docs/using.md
Outdated
!!! warning AutoRun in Genny is deprecated and no longer used | ||
|
||
AutoRun is no longer available in Genny. | ||
This documentation is kept for historical purposes only. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use caution blocks here that should be harder to miss.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonEismann This is the way to do admonitions in the Pine devprod docs, so it will be more visible there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pine also supports notes now:
https://docs.devprod.prod.corp.mongodb.com/performance/profiling_workflow/#heap-profiling-heaptrack
But I can see just doing the thing that looks good in Pine as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed at the onsite during the perf collab session, this is a good idea because the genny tasks are no longer expected to change much and we've learned the painful lesson that having evergreen configurations spread across multiple repos is hard to work with.
I would like to see the AutoRun blocks commented out in all workloads, with a corresponding comment explaining that it's deprecated. If possible, checking if the test defintion has an AutoRun block and failing immediately would provide a safe guard for any newly written tests. If the latter makes sense depends on how much work it would be.
Initially I thought this is a good thing to do in this PR as well. However, as mentioned in this PR here, AutoRun blocks are kept for backward compatibility with older older versions of the mongo repository. Do you think backward compatibility would be an obstacle for removing AutoRun blocks? Also, there's some Genny workload YML files in the 10gen/PrivateWorkloads repo with AutoRun blocks as well, should they be removed too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So happy to see Genny autotask going away, thank you team!
@@ -538,13 +538,16 @@ Examples with these and other Actors can be found in [./src/workloads/docs](../s | |||
|
|||
### What is AutoRun? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to modify the header to include the deprecation as well:
### What is AutoRun? | |
### What was AutoRun? |
I actually have a separate change on my machine to delete AutoRun blocks that I can apply whenever. I didn't want to muddy this PR with it. |
Co-authored-by: Minh Luu <PyGeek03@users.noreply.github.com>
Co-authored-by: Minh Luu <PyGeek03@users.noreply.github.com>
@SimonEismann per the above comment I have a followup PR that replaces all the autorun blocks with @PyGeek03 I think this change is already backwards incompatible with any PR that does task generation. This seems fine... it would only apply when using the latest version of Genny from an old version of Mongo and the workaround would be to mannually add the genny task info you want into DSI. I can add the workaround info to https://docs.google.com/document/d/1YzzrmKgIcpLG-60IdejYD4pxJzUQR-dy_nrrBgnLbBA/edit?tab=t.0 if that makes sense to do. |
We are switching over to using manually maintained files based in the DSI repo to run all Genny tasks. This removes any task generation functionality so that it doesn't cause confusion