chore(NODE-6018): run entire BSON suite on a big endian machine (#726)

mongodb · Nov 13, 2024 · 887849d · 887849d
1 parent eba09e7
commit 887849d
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 34 deletions.
diff --git a/.evergreen/config.yml b/.evergreen/config.yml
@@ -50,16 +50,6 @@ functions:
         args:
           - .evergreen/run-tests.sh
 
-  run big endian tests:
-    - command: subprocess.exec
-      type: test
-      params:
-        working_dir: src
-        add_expansions_to_env: true
-        binary: bash
-        args:
-          - .evergreen/run-big-endian-test.sh
-
   run checks:
     - command: subprocess.exec
       type: test
@@ -165,6 +155,14 @@ tasks:
           NODE_LTS_VERSION: 20
       - func: install dependencies
       - func: run tests
+  - name: node-tests-v22
+    tags: ["node"]
+    commands:
+      - func: fetch source
+        vars:
+          NODE_LTS_VERSION: 22
+      - func: install dependencies
+      - func: run tests
   - name: node-tests-latest
     tags: ["node"]
     commands:
@@ -180,7 +178,7 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_LTS_VERSION: 20
+          NODE_LTS_VERSION: 22
       - func: install dependencies
       - func: run tests
         vars:
@@ -189,15 +187,15 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_LTS_VERSION: 20
+          NODE_LTS_VERSION: 22
       - func: install dependencies
       - func: run bundling
   - name: no-bigint-web-tests
     tags: ["no-bigint", "web"]
     commands:
       - func: fetch source
         vars:
-          NODE_LTS_VERSION: 20
+          NODE_LTS_VERSION: 22
       - func: install dependencies
       - func: run tests
         vars:
@@ -209,14 +207,14 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_LTS_VERSION: 20
+          NODE_LTS_VERSION: 22
       - func: install dependencies
       - func: run checks
   - name: check-typescript-oldest
     commands:
       - func: fetch source
         vars:
-          NODE_LTS_VERSION: 20
+          NODE_LTS_VERSION: 22
       - func: install dependencies
       - func: "run typescript"
         vars:
@@ -226,7 +224,7 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_LTS_VERSION: 20
+          NODE_LTS_VERSION: 22
       - func: install dependencies
       - func: "run typescript"
         vars:
@@ -236,7 +234,7 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_LTS_VERSION: 20
+          NODE_LTS_VERSION: 22
       - func: install dependencies
       - func: "run typescript"
         vars:
@@ -288,28 +286,19 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_LTS_VERSION: 20
+          NODE_LTS_VERSION: 22
       - func: install dependencies
       - func: run eslint plugin tests
-  - name: node-tests-big-endian
-    commands:
-      - func: fetch source
-        vars:
-          NODE_LTS_VERSION: 20
-      - func: install dependencies
-        vars:
-          NPM_OPTIONS: "--ignore-scripts"
-      - func: run big endian tests
 
 buildvariants:
   - name: linux
     display_name: RHEL 8.0
     run_on: rhel80-small
     tasks: [".node", ".web", "check-eslint-plugin"]
   - name: linux-zseries
-    display_name: RHEL 8.3 zSeries
-    run_on: rhel83-zseries-small
-    tasks: ["node-tests-big-endian"]
+    display_name: RHEL 9.0 zSeries
+    run_on: rhel9-zseries-small
+    tasks: [".node", ".web"]
   - name: lint
     display_name: lint
     run_on: rhel80-small

diff --git a/test/s390x/big_endian.test.ts → test/node/big_endian.test.ts b/test/s390x/big_endian.test.ts → test/node/big_endian.test.ts
@@ -9,10 +9,10 @@ FLOAT[0] = -1;
 // Big endian    [191, 240, 0, 0, 0, 0, 0, 0]
 const isBigEndian = FLOAT_BYTES[7] === 0;
 
-context(`handles big endianness correctly`, () => {
+describe(`handles big endianness correctly`, () => {
   before(function () {
     if (!isBigEndian) {
-      throw new Error('expected to only run on big endian system');
+      this.skip();
     }
   });
 

diff --git a/test/node/double.test.ts b/test/node/double.test.ts
@@ -339,7 +339,9 @@ describe('BSON Double Precision', function () {
     expect(type).to.equal(BSON_DATA_NUMBER);
     expect(type).to.not.equal(BSON_DATA_INT);
     expect(serializedDouble.subarray(7, 15)).to.deep.equal(
-      new Uint8Array(new Float64Array([-0]).buffer)
+      // Use this on an LE system to re-create the following bytes:
+      // new Uint8Array(new Float64Array([-0]).buffer)
+      new Uint8Array([0, 0, 0, 0, 0, 0, 0, 128])
     );
   });
 

diff --git a/test/node/release.test.ts b/test/node/release.test.ts
@@ -66,6 +66,14 @@ const REQUIRED_FILES = [
 
 describe(`Release ${packFile}`, function () {
   let tarFileList;
+
+  before(function () {
+    if (process.arch !== 'x64') {
+      // This test doesn't need to run more than once on one of our platforms.
+      this.skip();
+    }
+  });
+
   before(function () {
     this.timeout(120_000); // npm pack can be slow
     expect(fs.existsSync(packFile), `expected ${packFile} to NOT exist`).to.equal(false);
@@ -81,7 +89,11 @@ describe(`Release ${packFile}`, function () {
   });
 
   after(() => {
-    fs.unlinkSync(packFile);
+    try {
+      fs.unlinkSync(packFile);
+    } catch (error) {
+      if (error.code !== 'ENOENT') throw error;
+    }
   });
 
   for (const requiredFile of REQUIRED_FILES) {