Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(NODE-4901): update guide about bundle changes #544

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Dec 16, 2022

Description

What is changing?

Update guide about bundle changes

Update readme examples about importing and using with bundlers

What is the motivation for this change?

Follow up to #534

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title chore(NODE-TODO): add bundles to repo and update guide chore(NODE-4901): add bundles to repo and update guide Dec 19, 2022
@nbbeeken nbbeeken force-pushed the NODE-XXXX-commit-bundles branch from fe257ef to c18ae7c Compare December 19, 2022 16:41
@nbbeeken nbbeeken changed the title chore(NODE-4901): add bundles to repo and update guide docs(NODE-4901): update guide about bundle changes Dec 19, 2022
@nbbeeken nbbeeken marked this pull request as ready for review December 19, 2022 17:03
@durran durran merged commit 2a503d1 into main Dec 19, 2022
@durran durran deleted the NODE-XXXX-commit-bundles branch December 19, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants