Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NODE-5362): update benchmark tooling #584

Merged
merged 5 commits into from
Jun 23, 2023
Merged

chore(NODE-5362): update benchmark tooling #584

merged 5 commits into from
Jun 23, 2023

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Jun 16, 2023 •
edited
Loading

Description

What is changing?

  • Adds a script that allows for easier installation of older bson versions for performance testing
  • Adds a script that converts benchmark output to easily ingestible csv data
  • Updates etc/benchmarks/lib_runner.js to more cleanly test old bson versions and generate clearer tabular output
Is there new documentation needed for these changes?

No, these are internal

What is the motivation for this change?

  • Making bson benchmarking easier following the investigation of NODE-4283

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James changed the title chore(NODE-4283): update benchmark tooling chore: update benchmark tooling Jun 20, 2023
@W-A-James W-A-James marked this pull request as ready for review June 20, 2023 14:14
@dariakp
Copy link
Contributor

dariakp commented Jun 20, 2023

@W-A-James Could you create a subtask on NODE-4283 to track this work?

@W-A-James W-A-James changed the title chore: update benchmark tooling chore(NODE-5362): update benchmark tooling Jun 20, 2023
@durran durran self-assigned this Jun 21, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 21, 2023
durran
durran requested changes Jun 21, 2023
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice table. :)

W-A-James and others added 3 commits June 21, 2023 15:49
@W-A-James W-A-James requested a review from durran June 21, 2023 20:06
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 21, 2023
@durran durran merged commit bc95ab4 into main Jun 23, 2023
@durran durran deleted the improve-benchmark-tooling branch June 23, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees

@durran durran

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@W-A-James @dariakp @durran