Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-5504)!: bump bson major version #605

Merged
merged 2 commits into from
Aug 3, 2023
Merged

feat(NODE-5504)!: bump bson major version #605

merged 2 commits into from
Aug 3, 2023

Conversation

durran
Copy link
Member

@durran durran commented Aug 2, 2023

Description

Bumps BSON_MAJOR_VERSION constant to 6.

What is changing?

Bumps BSON_MAJOR_VERSION constant to 6 and adds a test.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5504

Release Highlight

BSON_MAJOR_VERSION bumped to 6

Only BSON objects that have this major version can be serialized with this version of the library. Mismatched objects will throw a BSONVersionError when attempting to serialize.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James self-assigned this Aug 2, 2023
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're getting failures in CI because we have tests for what seems to be all of our BSON types that check for the @@mdb.bson.version flag that are failing to match the new value.

@nbbeeken nbbeeken changed the title feat(NODE-5504): bump bson major version feat(NODE-5504)!: bump bson major version Aug 2, 2023
@durran durran requested a review from W-A-James August 3, 2023 11:20
@W-A-James W-A-James merged commit 9615902 into main Aug 3, 2023
@W-A-James W-A-James deleted the NODE-5504 branch August 3, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants