fix(NODE-6123): utf8 validation is insufficiently strict #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it impact the performance ? |
billouboq
reviewed
Apr 24, 2024
aditi-khare-mongoDB
force-pushed
the
NODE-6123/stricter-toUTF8-validation
branch
from
0f34306 to
3768409
Compare
aditi-khare-mongoDB
force-pushed
the
NODE-6123/stricter-toUTF8-validation
branch
from
3768409 to
8d2ed1e
Compare
aditi-khare-mongoDB
added
the
Primary Review
nbbeeken
requested changes
Apr 25, 2024
nbbeeken
reviewed
Apr 29, 2024
nbbeeken
requested changes
Apr 29, 2024
aditi-khare-mongoDB
changed the title
aditi-khare-mongoDB
changed the title
nbbeeken
approved these changes
Apr 30, 2024
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Outside of web, our
toUtf8function was insufficiently strict and allowed overlong encodings.What is changing?
Change our functionality to use js
TextDecoderto double check utf8 input when a replacement character is detected.Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Drivers wide initiative to make UTF-8 validation strict and consistent.
UTF-8 validation now throws a
BSONErroron overlong encodings in Node.jsSpecifically, this affects
deserializewhen utf8 validation is enabled, which is the default.An overlong encoding is when the number of bytes in an encoding is inflated by padding the code point with leading 0s (see here for more information).
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript