Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use sarif report action from main #699

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

baileympearson
Copy link
Contributor

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

alcaeus
alcaeus previously approved these changes Jun 4, 2024
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add TODO comments to remind ourselves to eventually change this to v2, but LGTM with or without that change.

.github/workflows/release-5.x.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
Co-authored-by: Andreas Braun <git@alcaeus.org>
@baileympearson baileympearson merged commit b0f9264 into main Jun 4, 2024
8 checks passed
@baileympearson baileympearson deleted the no-story-use-action branch June 4, 2024 15:46
baileympearson added a commit that referenced this pull request Jun 13, 2024
Co-authored-by: Andreas Braun <git@alcaeus.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants