Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-6534): add spec test runner for Binary vector #729

Merged
merged 2 commits into from
Nov 15, 2024
Merged

test(NODE-6534): add spec test runner for Binary vector #729

merged 2 commits into from
Nov 15, 2024

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Sync new vector tests in BSON corpus
  • Add spec test runner for BSON vector tests
    • mark the parts of the test runner with TODOs that need to be in the final API.
Is there new documentation needed for these changes?

What is the motivation for this change?

Need the test runner to test correctness with respect to the spec.

Our make/convert APIs will have their own tests so I'm implementing this first to reduce review load.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review November 13, 2024 23:23
@baileympearson baileympearson self-assigned this Nov 15, 2024
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 15, 2024
@baileympearson baileympearson self-requested a review November 15, 2024 18:53
baileympearson
baileympearson requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nothing large, so still moving this to team review

test/node/bson_binary_vector.spec.test.ts Outdated Show resolved Hide resolved
test/node/bson_binary_vector.spec.test.ts Outdated Show resolved Hide resolved
test/node/bson_binary_vector.spec.test.ts Outdated Show resolved Hide resolved
test/node/bson_binary_vector.spec.test.ts Outdated Show resolved Hide resolved
test/node/bson_binary_vector.spec.test.ts Show resolved Hide resolved
@W-A-James W-A-James self-requested a review November 15, 2024 20:49
@baileympearson baileympearson merged commit f6e86bb into main Nov 15, 2024
8 checks passed
@baileympearson baileympearson deleted the NODE-6534-spec branch November 15, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

@W-A-James W-A-James Awaiting requested review from W-A-James

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @baileympearson