fix(NODE-6608): calculateObjectSize returns the wrong value for bigint #742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
This fixes a bug where the serializer produces something of a different size than what the calculate function claims it will.
Release Highlight
Fix
calculateObjectSize
not accounting forBigInt
value sizeBSON.calculateObjectSize
was missing a condition forBigInt
values, meaning it did not account for them in the same way that it would forLong
values. This has been corrected.We also added a new default condition that will catch any new values that may be returned by
typeof
in the future and will throw an error rather than returning an inaccurate size.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript