PHPORM-167 Fix and test MongoDB failed queue provider #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Apr 10, 2024
jmikola
approved these changes
Apr 15, 2024
| ->collection('failed_jobs') | ||
| ->raw() | ||
| ->insertMany(array_map(static fn ($i) => [ | ||
| '_id' => new ObjectId(sprintf('%024d', $i)), |
There was a problem hiding this comment.
Are _id fields within jobs always an ObjectId? I saw that MongoFailedJobProvider made some assumptions about that by using string for type hints and casting.
There was a problem hiding this comment.
Documents are added by the log method which doesn't specify _id. So we get an automatic ObjectId.
This was referenced Apr 23, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-167
In Laravel 11.35, the
DatabaseFailedJobProvider::idswas added in order to optimize loading this ids only instead of the full documents. laravel/framework#49186This implementation is not compatible with MongoDB since it references the field
idinstead of_id.Also, the method
DatabaseFailedJobProvider::pruneis not compatible with MongoDB because it tries to delete document by bulks of 1000, which is not supported. MongoDB can only delete one or all documents matching a criteria.I'm also adding tests to the methods inherited from the parent
DatabaseFailedJobProviderto ensure they work with a MongoDB connection.Checklist