feat(NODE-5420)!: remove JS bindings from libmongocrypt #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
5 tasks
baileympearson
changed the title
baileympearson
force-pushed
the
no-story-remove-logic-from-bindings
branch
from
d6928a8 to
8109f45
Compare
baileympearson
requested review from
nbbeeken,
durran,
dariakp and
addaleax
as code owners
durran
requested changes
Jul 13, 2023
baileympearson
force-pushed
the
no-story-remove-logic-from-bindings
branch
from
8109f45 to
d484295
Compare
durran
approved these changes
Jul 13, 2023
nbbeeken
requested changes
Jul 13, 2023
addaleax
reviewed
Jul 14, 2023
addaleax
reviewed
Jul 14, 2023
nbbeeken
requested changes
Jul 17, 2023
There was a problem hiding this comment.
I can check over the changes Anna requested, and there's some thumbs up but no change (the export one here). I think we only discussed the type tests offline, but post a "from slack: X" if I'm forgetting, ty!
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
nbbeeken
requested changes
Jul 18, 2023
…odb/libmongocrypt into no-story-remove-logic-from-bindings
baileympearson
changed the title
baileympearson
changed the title
nbbeeken
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large PR, but viewing commit-by-commit helps with the changes. The first commit removes all the JS files.
Summary of changes
addonfolder. Build scripts have been updated to look here.index.jsfile has been converted to TS, now lives insrcand contains TS types for theMongoCryptclass and the supporting C++ Javascript classes.preparescript has been added that builds the TS bindings and puts them in thelibfolder (copied from the driver).I suggest viewing this commit's diff: 077e61e