GODRIVER-2725 Allow setting Encoder and Decoder options on a Client. #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
force-pushed
the
godriver2725-set-enc-dec
branch
6 times, most recently
from
cbd1e7b
to
b424c99
Compare
matthewdale
force-pushed
the
godriver2725-set-enc-dec
branch
5 times, most recently
from
972e3d2
to
ce7e1bd
Compare
matthewdale
force-pushed
the
godriver2725-set-enc-dec
branch
from
582a826
to
b45ed59
Compare
matthewdale
force-pushed
the
godriver2725-set-enc-dec
branch
from
b45ed59
to
fe1ab18
Compare
prestonvasquez
requested changes
Jun 20, 2023
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
prestonvasquez
approved these changes
Jun 21, 2023
|
Setting BSONOptions does nothing because MergeCollectionOptions func ignores this attr. Is this a bug? |
|
@lexxxich yes that is a bug, thank you for the report! I've created GODRIVER-2937 to track that bug and the resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2725
Summary
bson.Encoderandbson.Decoderconfiguration options via a newoptions.BSONOptionsclient configuration value.BSONOptionsstruct more ergonomic.Background & Motivation
GODRIVER-2716 added a new API for configuring a
bson.Encoderandbson.Decoderthat replaces the configuration applied via thebsoncodecpackage. Users need a way to apply those configurations inmongo.Connectalso.