Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-2754 Update CI to go1.20 #1283

Merged
merged 3 commits into from
Jun 5, 2023
Merged

GODRIVER-2754 Update CI to go1.20 #1283

merged 3 commits into from
Jun 5, 2023

Conversation

prestonvasquez
Copy link
Collaborator

@prestonvasquez prestonvasquez commented Jun 2, 2023 •
edited
Loading

GODRIVER-2754

Summary

Fix linking error in CI, resolved resolved by proposal #47257 and released in go1.20.

Background & Motivation

The CI is giving the following linking errors on the windows distributions, documented in golang/go issue #51007.

[2023/06/02 15:42:38.833] C:/ProgramData/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\data\mci\936e62bf82f83d6fbca0373ed8892b0d\tmp\go-link-2805934583\000010.o: in function `x_cgo_thread_start':
[2023/06/02 15:42:38.833] \\_\_\runtime\cgo/gcc_util.c:18: undefined reference to `__imp___iob_func'

@prestonvasquez prestonvasquez changed the title update windows distro to vsCurrent-latest Update windows distro to vsCurrent-latest Jun 3, 2023
@prestonvasquez prestonvasquez changed the title Update windows distro to vsCurrent-latest Update CI to go1.20 Jun 3, 2023
@prestonvasquez prestonvasquez marked this pull request as ready for review June 3, 2023 00:09
qingyang-hu
qingyang-hu approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qingyang-hu
qingyang-hu approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

matthewdale
matthewdale approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Looks good 👍

Consider adding "GODRIVER-2754" to the PR title so it gets automatically linked to the Jira ticket.

@prestonvasquez prestonvasquez changed the title Update CI to go1.20 GODRIVER-2754 Update CI to go1.20 Jun 5, 2023
@prestonvasquez prestonvasquez merged commit cf14ffe into mongodb:master Jun 5, 2023
@prestonvasquez prestonvasquez deleted the update-windows-to-vscurrent-latest branch June 5, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingyang-hu qingyang-hu qingyang-hu approved these changes

@matthewdale matthewdale matthewdale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prestonvasquez @matthewdale @qingyang-hu