Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2819 Decode document into bson.D if there is no type info. #1682

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

qingyang-hu
Copy link
Collaborator

GODRIVER-2819

Summary

Decode document into bson.D if there is no type info.

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the priority-3-low Low Priority PR for Review label Jun 20, 2024
Copy link
Contributor

mongodb-drivers-pr-bot bot commented Jun 20, 2024

API Change Report

./bson

incompatible changes

(*DecodeContext).DefaultDocumentD: removed
(*Decoder).DefaultDocumentD: removed
DecodeContext.Ancestor: removed

./mongo/options

incompatible changes

BSONOptions.DefaultDocumentD: removed

@@ -108,6 +108,7 @@ func (ce *ClientEncryption) CreateEncryptedCollection(ctx context.Context,
}
r := bson.NewValueReader(efBSON)
dec := bson.NewDecoder(r)
dec.DefaultDocumentM()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, this is the only place to add DefaultDocumentM.

@qingyang-hu qingyang-hu marked this pull request as ready for review June 21, 2024 23:01
@qingyang-hu qingyang-hu requested review from prestonvasquez and matthewdale and removed request for prestonvasquez June 21, 2024 23:01
matthewdale
matthewdale previously approved these changes Jun 26, 2024
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@qingyang-hu qingyang-hu added priority-2-medium Medium Priority PR for Review and removed priority-3-low Low Priority PR for Review labels Jun 27, 2024
prestonvasquez
prestonvasquez previously approved these changes Jul 2, 2024
@qingyang-hu qingyang-hu merged commit 1768615 into mongodb:master Jul 16, 2024
27 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-2-medium Medium Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants