GODRIVER-2701 Implement a variant of DropIndex that gets keys rather than name #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: 56850c7 and before have an implementation of DropOne method taking in a generic of either the key or name which could be considered for 2.0. |
API Change Report./mongocompatible changesIndexView.DropWithKey: added ./x/mongo/driver/operationincompatible changes(*DropIndexes).Index: changed from func(string) *DropIndexes to func(any) *DropIndexes |
qingyang-hu
requested review from
prestonvasquez
and removed request for
blink1073
prestonvasquez
requested changes
Jun 26, 2024
timothy-kim-mongo
force-pushed
the
GODRIVER-2701
branch
from
e9bb168
to
5cefa42
Compare
prestonvasquez
requested changes
Jul 1, 2024
timothy-kim-mongo
force-pushed
the
GODRIVER-2701
branch
from
66a0dea
to
d1c21b1
Compare
timothy-kim-mongo
force-pushed
the
GODRIVER-2701
branch
from
b354e40
to
b9defa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2701
Summary
The changes in this pull-request answers the ticket GODRIVER-2701of implements a variant of DropIndex that searches for the index using the key rather than the name of the index. This creates an additional method that allows users to drop index with the freedom of either a name or key.
Background & Motivation
The motivation behind this is to be consistent with the functionality of the MongoDB db.collection.dropIndex() function which allows dropping the index with either a key or name. This is an optional part of the spec - https://github.com/mongodb/specifications/blob/master/source/index-management/index-management.md#standard-api.