GODRIVER-3260 [master] Code hardening #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
changed the title
|
zlib.net appears to be down, causing our link check to fail. |
API Change ReportNo changes found! |
qingyang-hu
reviewed
Jun 27, 2024
Comment on lines
+173
to
+175
| if w > math.MaxInt32 { | ||
| return 0, nil, fmt.Errorf("%d overflows int32", w) | ||
| } |
Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com>
matthewdale
previously approved these changes
Jun 28, 2024
qingyang-hu
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3260
Summary
Forward-port of all of the changes in #1684 except the ones to
default_value_decoders.go, since it did not cherry-pick cleanly.Background & Motivation
SSDLC compliance.