-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-2587 Implement modifyCollection for the unified test runner #1796
Conversation
API Change Report./v2/mongo/optionsincompatible changesBSONOptions.ObjectIDAsHexString: removed ./v2/x/mongo/driverincompatible changes##CursorOptions.MarshalValueEncoderFn: changed from func(io.Writer) ./v2/bson.Encoder to func(io.Writer) (./v2/bson.Encoder, error) |
This reverts commit 5c7fcc8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joyjwang Can you sync the JSON and YAML for tests the use collMod in the Go Driver: https://github.com/search?q=repo%3Amongodb%2Fspecifications+%5C%22collMod%5C%22+language%3AJSON&type=code
@joyjwang I apologize, I used the wrong search string. I meant to used "modifyCollection". Looking through the tests it looks like everything is covered, we can revert c1efef5 to keep this PR focused. We can also put the PR in "ready for review". |
@prestonvasquez the sync does add the test testdata/collection-management/modifyCollection-errorResponse.json which uses "modifyCollection", so would it be best to keep that and only revert the others? |
Yes, that sounds right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
drivers-pr-bot please backport to v1 |
GODRIVER-2587
Summary
Background & Motivation