Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2587 Implement modifyCollection for the unified test runner #1796

Merged
merged 7 commits into from
Sep 11, 2024

Conversation

joyjwang
Copy link
Contributor

@joyjwang joyjwang commented Sep 9, 2024

GODRIVER-2587

Summary

Background & Motivation

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the priority-3-low Low Priority PR for Review label Sep 9, 2024
Copy link
Contributor

API Change Report

./v2/mongo/options

incompatible changes

BSONOptions.ObjectIDAsHexString: removed

./v2/x/mongo/driver

incompatible changes

##CursorOptions.MarshalValueEncoderFn: changed from func(io.Writer) ./v2/bson.Encoder to func(io.Writer) (./v2/bson.Encoder, error)

@joyjwang joyjwang marked this pull request as ready for review September 9, 2024 20:50
@prestonvasquez prestonvasquez requested review from prestonvasquez and removed request for prestonvasquez September 9, 2024 23:21
@joyjwang joyjwang marked this pull request as draft September 10, 2024 17:22
Copy link
Collaborator

@prestonvasquez prestonvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prestonvasquez
Copy link
Collaborator

prestonvasquez commented Sep 10, 2024

@joyjwang Can you sync the JSON and YAML for tests the use collMod in the Go Driver: github.com/search?q=repo%3Amongodb%2Fspecifications+%5C%22collMod%5C%22+language%3AJSON&type=code

@joyjwang I apologize, I used the wrong search string. I meant to used "modifyCollection". Looking through the tests it looks like everything is covered, we can revert c1efef5 to keep this PR focused.

We can also put the PR in "ready for review".

@joyjwang
Copy link
Contributor Author

@prestonvasquez the sync does add the test testdata/collection-management/modifyCollection-errorResponse.json which uses "modifyCollection", so would it be best to keep that and only revert the others?

@joyjwang joyjwang marked this pull request as ready for review September 11, 2024 14:02
@prestonvasquez
Copy link
Collaborator

@prestonvasquez the sync does add the test testdata/collection-management/modifyCollection-errorResponse.json which uses "modifyCollection", so would it be best to keep that and only revert the others?

Yes, that sounds right.

Copy link
Collaborator

@prestonvasquez prestonvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joyjwang joyjwang merged commit 4f21584 into mongodb:master Sep 11, 2024
29 of 33 checks passed
@joyjwang
Copy link
Contributor Author

drivers-pr-bot please backport to v1

mongodb-drivers-pr-bot bot pushed a commit that referenced this pull request Sep 11, 2024
joyjwang added a commit that referenced this pull request Sep 13, 2024
…1796) [v1] (#1802)

Co-authored-by: Joy Wang <49984055+joyjwang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low Low Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants