-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-1855 Support AWS authentication with temporary credentials in CSFLE #580
GODRIVER-1855 Support AWS authentication with temporary credentials in CSFLE #580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a number of CSFLE-related test failures in the linked Evergreen patch. Can you investigate those before we review the changes? Feel free to reach out over Slack if you need help running the CSFLE stuff locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes mainly LGTM, but I have some clarifying questions to make sure I'm understanding everything before I approve.
Also @benjirewis can you mark the ticket as fixVersion 1.5.0 for tracking purposes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit but otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -293,6 +293,21 @@ functions: | |||
fi | |||
fi | |||
|
|||
# Set temp credentials for AWS if python3 is available. | |||
# | |||
# Using python3-venv in Ubuntu 14.04 (an OS required for legacy server version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is helpful info.
GODRIVER-1855
Adds support for temporary AWS credentials in spec test helpers.
Adds new
awsTemporary
spec tests. Updates client-side-encryption test README.