Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-1855 Support AWS authentication with temporary credentials in CSFLE #580

Merged
merged 7 commits into from
Mar 5, 2021
Merged

GODRIVER-1855 Support AWS authentication with temporary credentials in CSFLE #580

merged 7 commits into from
Mar 5, 2021

Conversation

benjirewis
Copy link
Contributor

GODRIVER-1855

Adds support for temporary AWS credentials in spec test helpers.

Adds new awsTemporary spec tests. Updates client-side-encryption test README.

Copy link
Contributor

@divjotarora divjotarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a number of CSFLE-related test failures in the linked Evergreen patch. Can you investigate those before we review the changes? Feel free to reach out over Slack if you need help running the CSFLE stuff locally.

Copy link
Contributor

@divjotarora divjotarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes mainly LGTM, but I have some clarifying questions to make sure I'm understanding everything before I approve.

.evergreen/config.yml Outdated Show resolved Hide resolved
mongo/integration/json_helpers_test.go Show resolved Hide resolved
.evergreen/config.yml Show resolved Hide resolved
@divjotarora
Copy link
Contributor

Also @benjirewis can you mark the ticket as fixVersion 1.5.0 for tracking purposes?

Copy link
Contributor

@divjotarora divjotarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but otherwise LGTM.

.evergreen/config.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -293,6 +293,21 @@ functions:
fi
fi

# Set temp credentials for AWS if python3 is available.
#
# Using python3-venv in Ubuntu 14.04 (an OS required for legacy server version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is helpful info.

@benjirewis benjirewis merged commit 8307eb1 into mongodb:master Mar 5, 2021
@benjirewis benjirewis deleted the supportAWSTempCreds.1855 branch March 5, 2021 23:05
faem pushed a commit to kubedb/mongo-go-driver that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants