-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-1919 Add object id decoder awareness of string hex #610
GODRIVER-1919 Add object id decoder awareness of string hex #610
Conversation
cd791e6
to
bddde89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your contribution to the driver @gl-ot ! I've authorized the CI patch build, and it looks like everything passes. We'll merge this and/or request changes once other team members have reviewed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @gl-ot! Just one small comment from me, but otherwise the change looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I authorized a new CI patch, but this looks great. Thanks again!
Try to run this code
You'll get an
ObjectID string must be exactly 12 bytes long
. Obvious bug