-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Hibernate ORM dependency version #16
Merged
NathanQingyangXu
merged 8 commits into
mongodb:main
from
NathanQingyangXu:bump-hibernate-orm-dependency
Nov 18, 2024
Merged
Bump Hibernate ORM dependency version #16
NathanQingyangXu
merged 8 commits into
mongodb:main
from
NathanQingyangXu:bump-hibernate-orm-dependency
Nov 18, 2024
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we need to manually add license to package-info.java
NathanQingyangXu
changed the title
Bump Hibernate ORM dependency
Bump Hibernate ORM dependency version
Nov 15, 2024
stIncMale
requested changes
Nov 18, 2024
Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
@@ -149,7 +149,7 @@ ij_java_method_parameters_right_paren_on_new_line = false | |||
ij_java_method_parameters_wrap = off | |||
ij_java_modifier_list_wrap = false | |||
ij_java_multi_catch_types_wrap = normal | |||
ij_java_names_count_to_use_import_on_demand = 3 | |||
ij_java_names_count_to_use_import_on_demand = 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the above changes will end up with solving the annoying import static wildcard
issue which troubled me all the time.
Spotless decides to ignore such common issue due to backward compatibility: diffplug/spotless#649, unfortunately
stIncMale
reviewed
Nov 18, 2024
Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
stIncMale
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from v6.6.1.Final to v6.6.2.Final with more than 50 bugfix related commits (https://hibernate.atlassian.net/issues/?jql=project%20%3D%20HHH%20AND%20fixVersion%20in%20%286.6.2%29%20ORDER%20BY%20updated)
also renamed the spotless license file to avoid confusion (original
copyright.txt
would make people assume it is the generic stuff, but it is spotless-specific; the naming is copied from Hibernate ORM (https://github.com/hibernate/hibernate-orm/blob/main/spotless.license.java).Better naming suggesiton is welcome!