Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force unique clusterTime values by splitting insert into two commands #1356

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

jyemin
Copy link
Contributor

@jyemin jyemin commented Apr 1, 2024

@jyemin jyemin requested a review from rozza April 1, 2024 19:16
@jyemin jyemin self-assigned this Apr 1, 2024
// write operation, and the test relies on the clusterTime values being both ascending _and_ unique.
def expectedOne = insertDocuments(helper, [1])
def expectedTwo = insertDocuments(helper, [2])
def expected = []
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure there is a more idiomatic one liner that will do this but I didn't think it was important enough to research. :)

Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…/ChangeStreamOperationSpecification.groovy

Co-authored-by: Maxim Katcharov <maxim.katcharov@mongodb.com>
@jyemin jyemin merged commit db1bb1d into mongodb:master Apr 2, 2024
2 of 3 checks passed
@jyemin jyemin deleted the j5397 branch April 2, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants