Remove deprecated field from GridFS unified tests #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joykim1005
changed the title
joykim1005
changed the title
joykim1005
requested review from
a team and
stIncMale
and removed request for
a team
stIncMale
requested changes
Dec 10, 2024
| "description": "gridfs-delete", | ||
| "schemaVersion": "1.0", | ||
| "createEntities": [ | ||
| "description" : "gridfs-delete", |
There was a problem hiding this comment.
The commit with the changes that were supposed to be merged to our repository, removed 60 lines from delete.json, yet here we many more lines affected. The issue seem to be caused by the extra spaces before :, which are not supposed to be there, and was likely introduced by auto-formatting you have enabled in the IDE.
The rest of the modified files have the same issue.
There was a problem hiding this comment.
Sorry, I was unaware about the auto-formatting. Will push in the changes with auto-formatting disabled!
stIncMale
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
JAVA-5709
Description
Spec tests for the GridFS spec have been updated to no longer include the deprecated
md5,contentType, andaliasesfields. This PR removes the use of deprecated fields from the GridFS unified tests by syncing the gridfs spec tests to commit 12be2dfab99bdad54c3499174b0519ddb4588332.Testing
UnifiedGridFSTest