Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dependabot for github-actions #1467

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Sep 12, 2023

@GromNaN GromNaN requested review from jmikola and alcaeus September 12, 2023 13:08
@@ -0,0 +1,6 @@
version: 2
updates:
- package-ecosystem: "github-actions"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this accomplish for PHPC? Our only direct dependencies are the libmongoc and libmongocrypt submodules, and I doubt it's going to help us write Autoconf files :)

Would this be better suited to PHPLIB? I see that Composer is handled within dependabot/dependabot-core.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only about github-actions dependencies. It opens PRs like this: mongodb/mongo-php-library#1159

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmikola FWIW, Dependabot could open pull requests for updates to submodules, but it currently can't handle tags and can only update to the latest commit.

I'm fine with having automatic updates to GitHub Actions dependencies so we don't have to manually keep track of them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my mistake for not realizing what package-ecosystem: "github-actions" did. SGTM.

@GromNaN GromNaN merged commit 10614ac into mongodb:master Sep 12, 2023
@GromNaN GromNaN deleted the dependabot branch September 12, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants