PYTHON-3798 add error checking and visit for _type_marker_str (#1291)

mongodb · Jul 6, 2023 · c7432db · c7432db
1 parent 32b2b32
commit c7432db
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/bson/_cbsonmodule.c b/bson/_cbsonmodule.c
@@ -469,7 +469,9 @@ static int _load_python_objects(PyObject* module) {
     struct module_state *state = GETSTATE(module);
 
     /* Python str for faster _type_marker check */
-    state->_type_marker_str = PyUnicode_FromString("_type_marker");
+    if (!(state->_type_marker_str = PyUnicode_FromString("_type_marker"))) {
+        return 1;
+    }
 
     if (_load_object(&state->Binary, "bson.binary", "Binary") ||
         _load_object(&state->Code, "bson.code", "Code") ||
@@ -3043,6 +3045,7 @@ static int _cbson_traverse(PyObject *m, visitproc visit, void *arg) {
     Py_VISIT(GETSTATE(m)->MaxKey);
     Py_VISIT(GETSTATE(m)->UTC);
     Py_VISIT(GETSTATE(m)->REType);
+    Py_VISIT(GETSTATE(m)->_type_marker_str);
     return 0;
 }