Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-4982 Remove redundant configureFailPoint #2012

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ShaneHarvey
Copy link
Member

PYTHON-4982 Remove redundant configureFailPoint

This shouldn't resolve all the issues but it's worth removing the redundant code.

@@ -174,9 +174,8 @@ async def test_retryable_reads_in_sharded_cluster_multiple_available(self):
retryReads=True,
)

async with self.fail_point(fail_command):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already set the failpoint on both mongoses above.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShaneHarvey ShaneHarvey merged commit ddf783b into mongodb:master Nov 19, 2024
44 of 46 checks passed
@ShaneHarvey ShaneHarvey deleted the PYTHON-4982 branch November 20, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants