RUST-1505 Convert remaining event handler types to new API #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Jan 19, 2024
| @@ -93,20 +91,6 @@ impl Event { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug, Serialize)] | |||
| #[serde(untagged)] | |||
| pub(crate) enum SdamEvent { | |||
There was a problem hiding this comment.
I don't know why we had two of these.
isabelatkinson
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1505
This updates
cmap_event_handlerandsdam_event_handlerto use the new API. There are a lot of little changes but this is a fairly mechanical PR, it's all following the same pattern ascommand_event_handlerdid.