Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUST-1652 Add a find_one method to GridFsBucket #1015

Merged
merged 5 commits into from
Jan 25, 2024
Merged

RUST-1652 Add a find_one method to GridFsBucket #1015

merged 5 commits into from
Jan 25, 2024

Conversation

kkloberdanz
Copy link
Contributor

No description provided.

@kkloberdanz
RUST-1652 Add a find_one method to GridFsBucket
7b5206c 
This also creates a new struct GridFsFindOneOptions, which is used to
pass options to the new find_one method.
@kkloberdanz
Test the new GridFsBucket::find_one() method
f65fc2d
@kkloberdanz
Use new GridFsBucket.find_one() method
df0575d 
Convert calls to GridFsBucket.files().find_one() to the equivalent call
to GridFsBucket.find_one()
abr-egn
abr-egn approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

isabelatkinson
isabelatkinson approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two small suggestions, otherwise looks good! feel free to merge after applying changes

src/gridfs.rs Outdated Show resolved Hide resolved
src/test/spec/gridfs.rs Outdated Show resolved Hide resolved
kkloberdanz and others added 2 commits January 25, 2024 11:01
@kkloberdanz @isabelatkinson
Update src/gridfs.rs
58178dc 
Co-authored-by: Isabel Atkinson <isabelatkinson@gmail.com>
@kkloberdanz
Remove async from find one options test
edb26e2
@kkloberdanz kkloberdanz merged commit 7f0d356 into mongodb:main Jan 25, 2024
16 checks passed
@kkloberdanz kkloberdanz deleted the RUST-1652 branch January 25, 2024 20:05
@kkloberdanz kkloberdanz mentioned this pull request Jan 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelatkinson isabelatkinson isabelatkinson approved these changes

@abr-egn abr-egn abr-egn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkloberdanz @abr-egn @isabelatkinson