Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add usage when wrong set of parameters #527

Merged
merged 2 commits into from
Nov 23, 2020
Merged

fix: add usage when wrong set of parameters #527

merged 2 commits into from
Nov 23, 2020

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Nov 20, 2020

Proposed changes

Closes #202

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

)

// NoArgs returns an error if any args are included.
func NoArgs(cmd *cobra.Command, args []string) error {
Copy link
Collaborator Author

@gssbzn gssbzn Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are the actual changes, the rest is just changing to use this package instead of the cobra one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 Now that's a ripple effect

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, now we know we have a bout 150+ commands 🤷‍♂️

Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit 05ca749 into master Nov 23, 2020
@gssbzn gssbzn deleted the fix-202 branch November 23, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage text is not shown when usage is incorrect
2 participants