feat(NODE-5077): automatic Azure kms credential refresh #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-5077-azure-kms-providers
branch
from
f1b484d
to
0e28ddf
Compare
baileympearson
changed the title
baileympearson
force-pushed
the
NODE-5077-azure-kms-providers
branch
2 times, most recently
from
c7b9729
to
06c4263
Compare
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
Mar 16, 2023
...gration/client-side-encryption/client_side_encryption.prose.18.azure_kms_mock_server.test.ts
Outdated
Show resolved
Hide resolved
...gration/client-side-encryption/client_side_encryption.prose.18.azure_kms_mock_server.test.ts
Outdated
Show resolved
Hide resolved
...gration/client-side-encryption/client_side_encryption.prose.18.azure_kms_mock_server.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.19.on_demand_azure.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.19.on_demand_azure.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
baileympearson
force-pushed
the
NODE-5077-azure-kms-providers
branch
from
956f7d0
to
619bdc1
Compare
nbbeeken
requested changes
Mar 20, 2023
...gration/client-side-encryption/client_side_encryption.prose.18.azure_kms_mock_server.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
requested changes
Mar 20, 2023
baileympearson
force-pushed
the
NODE-5077-azure-kms-providers
branch
from
ed51e1d
to
13b8520
Compare
nbbeeken
approved these changes
Mar 20, 2023
nbbeeken
added
Team Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Spec tests for Azure KMS on-demand credential refresh are added.
There are two sets of spec tests:
The integration tests run in their own build variant, since they require special setup and teardown.
The mock server tests run during all normal driver CI runs where FLE tests are run. To enable this, a new task was added that launches a mock Azure IDMS server (from drivers evergreen tools).
Is there new documentation needed for these changes?
No.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript