Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-5739): update data lake test scripts #3918

Merged
merged 2 commits into from
Nov 10, 2023
Merged

test(NODE-5739): update data lake test scripts #3918

merged 2 commits into from
Nov 10, 2023

Conversation

durran
Copy link
Member

@durran durran commented Nov 9, 2023 •
edited
Loading

Description

Updates the driver to use the new tools data lake test scripts so we don't occasionally fail when the DL team makes breaking changes to their configs. They now own the drivers config on the image and will update them when they make breaking changes.

What is changing?

  • Updates our evergreen config to use the new pull-mongohouse-image.sh and run-mongohouse-image.sh scripts.
  • Moves Data Lake tests to an Ubuntu 22 variant as these will not work on RHEL8
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5739

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review November 9, 2023 17:42
@durran durran changed the title test(NODE-5732): update data lake test scripts (#3913) test(NODE-5739): update data lake test scripts (#3913) Nov 9, 2023
@durran durran changed the title test(NODE-5739): update data lake test scripts (#3913) test(NODE-5739): update data lake test scripts Nov 9, 2023
@nbbeeken nbbeeken mentioned this pull request Nov 10, 2023
Merged
5 tasks
@nbbeeken nbbeeken self-assigned this Nov 10, 2023
@nbbeeken nbbeeken self-requested a review November 10, 2023 18:43
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 10, 2023
nbbeeken
nbbeeken approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CSFLE socks5 tests timeout for an unrelated reason

@nbbeeken nbbeeken merged commit 6266734 into 5.x Nov 10, 2023
19 of 20 checks passed
@nbbeeken nbbeeken deleted the NODE-5739 branch November 10, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@durran @nbbeeken