Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-6008): deprecate CloseOptions interface #4030

Merged
merged 21 commits into from
Mar 11, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Mar 8, 2024

Description

What is changing?

  • Deprecated CloseOptions interface
Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-6008

Release Highlight

Deprecated unused CloseOptions interface

The CloseOptions interface was unintentionally made public and was only intended for use in the driver's internals. Due to recent refactoring (NODE-5915), this interface is no longer used in the driver. Since it was marked public, out of an abundance of caution we will not be removing it outside of a major version, but we have deprecated it and will be removing it in the next major version.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@aditi-khare-mongoDB aditi-khare-mongoDB added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 8, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB self-assigned this Mar 8, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB self-requested a review March 8, 2024 21:40
@baileympearson
Copy link
Contributor

@W-A-James Is the base branch for this PR correct? (CI didn't run because it's not pointing to main)

Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes are minimal and LGTM, but do we know what's going on with the Ci alias?

@baileympearson baileympearson changed the base branch from NODE-5915/refactor-topology-close-to-be-synchronous to main March 8, 2024 21:52
@baileympearson
Copy link
Contributor

evergreen retry

@W-A-James
Copy link
Contributor Author

@W-A-James Is the base branch for this PR correct? (CI didn't run because it's not pointing to main)

I didn't want to mark this as internal until we actually stop using it (once NODE-5915 is merged), so I pointed it at the branch with the changes that remove its usages.

@aditi-khare-mongoDB aditi-khare-mongoDB self-requested a review March 11, 2024 18:01
@aditi-khare-mongoDB aditi-khare-mongoDB removed the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants