-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-6008): deprecate CloseOptions interface #4030
Conversation
… github.com:mongodb/node-mongodb-native into NODE-5915/refactor-topology-close-to-be-synchronous
@W-A-James Is the base branch for this PR correct? (CI didn't run because it's not pointing to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes are minimal and LGTM, but do we know what's going on with the Ci alias?
evergreen retry |
I didn't want to mark this as internal until we actually stop using it (once NODE-5915 is merged), so I pointed it at the branch with the changes that remove its usages. |
Description
What is changing?
CloseOptions
interfaceIs there new documentation needed for these changes?
No
What is the motivation for this change?
NODE-6008
Release Highlight
Deprecated unused
CloseOptions
interfaceThe
CloseOptions
interface was unintentionally made public and was only intended for use in the driver's internals. Due to recent refactoring (NODE-5915), this interface is no longer used in the driver. Since it was marked public, out of an abundance of caution we will not be removing it outside of a major version, but we have deprecated it and will be removing it in the next major version.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript