-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-6242): close becomes true after calling close when documents still remain #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Jun 27, 2024
durran
approved these changes
Jun 27, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Fix a change in behavior to close introduced in a recent cursor refactor. The expectation was that close became true when no more documents remain locally.
Is there new documentation needed for these changes?
Yes, API docs updated.
What is the motivation for this change?
The closed flag is used to determine if there are docs remaing in mongosh
Release Highlight
Clarified cursor state properties
The cursor has a few properties that represent the current state from the perspective of the driver and server. This PR corrects an issue that never made it to a release but we would like to take the opportunity to re-highlight what each of these properties mean.
cursor.closed
-cursor.close()
has been called, and there are no more documents stored in the cursor.cursor.killed
-cursor.close()
was called while the cursor still had a non-zero id, and the driver sent a killCursors command to free server-side resourcescursor.id == null
- The cursor has yet to send it's first command (ex.find
,aggregate
)cursor.id.isZero()
- The server sent the driver a cursor id of0
indicating a cursor no longer exists on the server side because all data has been returned to the driver.cursor.bufferedCount()
- The amount of documents stored locally in the cursor.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript