-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-6327): new client bulk write types and builders #4205
Conversation
1cb2bf1
to
fff99b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The testing made the PR straightforward to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small docs change and waiting for CI. Otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Keep in mind this is going in as a feat but no release notes understandably because a later PR will include the actual API. So we'll just want to remember to omit this bullet from next release.
CI failures are unrelated. |
Description
Creates the new client bulk write model types and options as well as the builders for the bulk write command.
What is changing?
ops
field of the bulk write command is a document sequencensInfo
field of the bulk write command is a unique document sequence.Is there new documentation needed for these changes?
None. docs changes will come on the last ticket of the epic as well as the release highlights.
What is the motivation for this change?
NODE-6327
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript