Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6400): migrate node download script to drivers-tools #4244

Merged
merged 19 commits into from
Oct 10, 2024

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Migrate to shared drivers script for node download, mainly to get retry on curl failure
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Remove flaky curl failure

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title chore(NODE-5845): migrate node download script to drivers-tools chore(NODE-6400): migrate node download script to drivers-tools Sep 27, 2024
@dariakp dariakp marked this pull request as draft September 27, 2024 15:51
@nbbeeken nbbeeken force-pushed the chore-node-5845 branch 2 times, most recently from 0e65ef7 to bd75752 Compare October 8, 2024 19:57
@nbbeeken nbbeeken marked this pull request as ready for review October 9, 2024 20:18
@W-A-James W-A-James self-assigned this Oct 9, 2024
@W-A-James W-A-James self-requested a review October 9, 2024 20:41
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 9, 2024
.evergreen/copy-driver-to-azure-and-run.sh Outdated Show resolved Hide resolved
.evergreen/copy-driver-to-azure-and-run.sh Outdated Show resolved Hide resolved
@W-A-James W-A-James merged commit 27618ae into main Oct 10, 2024
30 checks passed
@W-A-James W-A-James deleted the chore-node-5845 branch October 10, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants