Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 DOP-4597 update the engines dependency version #1087

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

caesarbell
Copy link
Collaborator

@caesarbell caesarbell commented May 6, 2024

Stories/Links:

DOP-4597

Current Behavior:

Put a link to current staging or production behavior, if applicable

Staging Links:

Staged Commit

Notes:

This just updates the pakcage.json engines.npm to support npm version 9.x. When using npm v9.5 local builds succeed, all tests pass, and staging commit builds succeed. Everything seems to work as expected.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@caesarbell caesarbell marked this pull request as ready for review May 6, 2024 21:06
Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@caesarbell caesarbell merged commit 7a007c9 into main May 7, 2024
2 checks passed
@caesarbell caesarbell deleted the DOP-4597 branch May 7, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants