Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-4672 - Allows the background styles to be influenced by the dark mode value from it's context #1100

Merged
merged 10 commits into from
May 29, 2024
Merged

DOP-4672 - Allows the background styles to be influenced by the dark mode value from it's context #1100

merged 10 commits into from
May 29, 2024

Conversation

caesarbell
Copy link
Collaborator

Stories/Links:

DOP-4672

Current Behavior:

Atlas

Staging Links:

Stagged Atlas

Notes:

  • Body is now influenced by the mode selected, i.e. when a user clicks the toggle button, the new styles for the background color and text will be applied.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@caesarbell caesarbell changed the title [DOP-4671 Merge in DOP-4671 First] DOP-4672 [Merge in DOP-4671 First] : DOP-4672 May 28, 2024
seungpark
seungpark reviewed May 29, 2024
View reviewed changes
Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM, as far as changes independent from DOP-4671. minor comments below but overall looks great!

src/styles/global-dark-mode.css Show resolved Hide resolved
src/styles/mongodb-docs.css Show resolved Hide resolved
mmeigs
mmeigs reviewed May 29, 2024
View reviewed changes
Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Two overall nits:

  • Make sure not to merge until you've first merged in the change I asked for in DOP-4667 PR
  • Remember to add context to the title of the PR

@caesarbell caesarbell changed the title [Merge in DOP-4671 First] : DOP-4672 [Merge in DOP-4667 First] : DOP-4672 - Allows the background styles to be influenced by the dark mode value from it's context May 29, 2024
@caesarbell caesarbell changed the title [Merge in DOP-4667 First] : DOP-4672 - Allows the background styles to be influenced by the dark mode value from it's context DOP-4672 - Allows the background styles to be influenced by the dark mode value from it's context May 29, 2024
@caesarbell caesarbell merged commit 59d36e0 into main May 29, 2024
2 checks passed
@caesarbell caesarbell deleted the DOP-4672 branch May 29, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmeigs mmeigs mmeigs approved these changes

@rayangler rayangler Awaiting requested review from rayangler

@seungpark seungpark Awaiting requested review from seungpark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caesarbell @seungpark @mmeigs