-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-4660: Applies dark mode to the Vertical Procedures and Steps Component #1101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good.
I do think we all should probably decide on our preferred approach.
Do we use the context in DocumentBody and pass the prop through everything? Or should we use the context in each (parent) component and only pass down if there are children that need it (meaning, not children that pass through the ComponentFactory)?
Or some other pattern. Pros and cons, etc.
|
This comment was marked as outdated.
This comment was marked as outdated.
I have updated this PR, I believe it makes more sense to leverage the |
Stories/Links:
DOP-4660
Current Behavior:
Atlas: Get Started
Click on the Atlas UI tab and verify the Vertical Procedures Component
Atlas: Connect to your Atlas Cluster
Verify the Steps Component
Staging Links:
Staged Atlas: Get Started
Click on the Atlas UI tab and verify the Vertical Procedures Component
Staged Altas: Connect to your Atlas Cluster
Verify the Steps Component
Notes:
README updates