Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lang-based redirect for now #1133

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Remove lang-based redirect for now #1133

merged 3 commits into from
Jun 14, 2024

Conversation

rayangler
Copy link
Collaborator

@rayangler rayangler commented Jun 14, 2024

Current Behavior:

Server docs

Staging Links:

Server docs

Notes:

  • Removing usage of this script for now due to user feedback about not knowing how to switch back to English site through the locale selector. The plan is to re-enable this feature again once DOP-4715 is unblocked and fully functional so that users can have the locale selector more visible on the top nav.
  • To test on the staging link, make sure to remove preferred_locale from local storage if it is set to en-us and set a browser language to a supported language like Portuguese (make sure it's the primary language, above English). The staging link should not cause a redirect.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@rayangler rayangler marked this pull request as ready for review June 14, 2024 20:12
@rayangler rayangler merged commit ad2583c into main Jun 14, 2024
2 checks passed
@rayangler rayangler deleted the remove-lang-script branch June 14, 2024 20:14
rayangler added a commit that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants