Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5273: add console warning for column out of index and continue #1339

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

seungpark
Copy link
Collaborator

Stories/Links:

DOP-5273

Current Behavior:

On the main branch, building a wrongly structured ListTable can produce an error in the build step for ListTables.
See this build log and search for ListTable. This resulted in the front end throwing an error at build time.

An example of badly structured ListTable). This row has too many columns (12) even though the table only has 9 columns.

Staging Links:

Staging link with test RST with too many items in row

Above link shows a console warning ListTable.js:218 Row has too many items (index 9) for table with 9 columns if too many items are included for that row. This is being tested with the above example RST

Notes:

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for docs-frontend-dotcomstg ready!

Name Link
🔨 Latest commit 81e1d9f
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomstg/deploys/678fcbce5d226700081070d5
😎 Deploy Preview https://deploy-preview-1339--docs-frontend-dotcomstg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for docs-frontend-stg ready!

Name Link
🔨 Latest commit 81e1d9f
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-stg/deploys/678fcbcefdca6600087c8199
😎 Deploy Preview https://deploy-preview-1339--docs-frontend-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seungpark seungpark requested review from mmeigs and rayangler January 17, 2025 20:38
Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this!

@seungpark seungpark merged commit 3b3e8a9 into main Jan 21, 2025
10 checks passed
@seungpark seungpark deleted the DOP-5273 branch January 21, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants