Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-716 skip bulkWrite tests on Atlas Serverless #1636

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

kevinAlbs
Copy link
Contributor

@kevinAlbs kevinAlbs commented Aug 21, 2024

Summary

Follow-up to #1534. Skip tests running bulkWrite on Atlas Serverless.

Background & Motivation

CLOUDP-256344 blocks bulkWrite in Atlas Serverless. This can be seen with mongosh:

Atlas test> db.version()
8.0.0-rc17
Atlas test> db.adminCommand({bulkWrite: 1, ops: [{insert: 0, document: {foo: "bar"}}], nsInfo: [{ns: "db.coll"}]})
MongoServerError[AtlasError]: (Unauthorized) not authorized on admin to execute command { bulkWrite: 1, ops: [[{insert 0} {document [{foo bar}]}]], nsInfo: [[{ns db.coll}]], lsid: { id: {4 [149 137 108 46 117 126 74 218 185 29 250 199 40 40 23 131]} }, $clusterTime: { clusterTime: {1724242370 2}, signature: { hash: {0 [31 9 179 21 13 4 43 10 142 148 251 52 224 5 220 242 224 236 216 151]}, keyId: 7364078628537106432.000000 } }, $db: "admin" }

Some unified tests required increasing schemaVersion to 1.4 to include support specifying serverless as a runOnRequirement.


Please complete the following before merging:

  • [ ] Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver. (Tested in Python)
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@kevinAlbs
Copy link
Contributor Author

@shruti-sridhar may I request trying these test files with the Python implementation? C does not currently test serverless in Evergreen, and Rust has an open ticket to investigate serverless test failures.

Copy link

@shruti-sridhar shruti-sridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested these on the serverless Evergreen tasks with the Python implementation and they're successfully skipped! They also pass on the 8.0 standalone, replica set, and sharded cluster tasks. Here's the link to the run.

@kevinAlbs kevinAlbs marked this pull request as ready for review August 21, 2024 18:55
@kevinAlbs kevinAlbs requested review from a team as code owners August 21, 2024 18:55
@kevinAlbs kevinAlbs requested review from durran, vector-of-bool, aditi-khare-mongoDB, nbbeeken, dariakp, isabelatkinson and a team and removed request for a team, nbbeeken and dariakp August 21, 2024 18:55
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, changes pass in Rust

@kevinAlbs kevinAlbs merged commit 0984b09 into mongodb:master Aug 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants