Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets Variable of Wrong Type #44

Closed
sethsaperstein opened this issue Nov 22, 2020 · 2 comments
Closed

Secrets Variable of Wrong Type #44

sethsaperstein opened this issue Nov 22, 2020 · 2 comments
Labels

Comments

@sethsaperstein
Copy link
Contributor

Secrets in variables is listed as list(string) but per aws documentation, the format of a secret is as follows: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_Secret.html

Thus type should be list(map(string)) since secrets is later json encoded.
Correct me if I'm using this improperly of course :)

@davidstoker
Copy link

I ran into this trying to use this module as well. In current form, a list(any) to be similar to other fields like portMappings would work. A more proper definition could be used too since it's a defined format as seen in the docs:

type = list(object({
    name      = string
    valueFrom = string
  }))

jasonwalsh pushed a commit that referenced this issue Dec 7, 2020
github-actions bot pushed a commit that referenced this issue Dec 7, 2020
## [2.1.3](v2.1.2...v2.1.3) (2020-12-07)

### Bug Fixes

* secrets type to list(map(string)) ([#45](#45)) ([78bf0c3](78bf0c3)), closes [#44](#44)
@github-actions
Copy link

github-actions bot commented Dec 7, 2020

🎉 This issue has been resolved in version 2.1.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants