Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gridfs): Adapt code to refactored Mongo driver GridFS implementation #905

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

mdomke
Copy link
Member

@mdomke mdomke commented Nov 6, 2024

Closes #903

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.96%. Comparing base (d821f32) to head (f5472ac).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
mongomock/gridfs.py 93.75% 1 Missing ⚠️
tests/test__gridfs.py 97.29% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #905   +/-   ##
========================================
  Coverage    95.95%   95.96%           
========================================
  Files           35       35           
  Lines         9989    10002   +13     
========================================
+ Hits          9585     9598   +13     
  Misses         404      404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdomke mdomke merged commit b233622 into develop Nov 6, 2024
9 checks passed
@P-EB
Copy link

P-EB commented Nov 9, 2024

Dear @mdomke ,

Do you have plan to release 4.3.X soon or should I consider backporting this PR into Debian, as mongomock is currently not functional there?

Both are fine, I'd just rather use a new release if it's coming soon.

Bests,
PEB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError with enable_gridfs_integration() with pymongo 4.9+
2 participants