fix: throw error if no function passed to pre/post

Re: Automattic/mongoose#8087
mongoosejs · Aug 22, 2019 · c0dd81c · c0dd81c
1 parent 71e24f4
commit c0dd81c
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -395,6 +395,10 @@ Kareem.prototype.pre = function(name, isAsync, fn, error, unshift) {
     ++pres.numAsync;
   }
 
+  if (typeof fn !== 'function') {
+    throw new Error('pre() requires a function, got "' + typeof fn + '"');
+  }
+
   if (unshift) {
     pres.unshift(Object.assign({}, options, { fn: fn, isAsync: isAsync }));
   } else {
@@ -413,6 +417,10 @@ Kareem.prototype.post = function(name, options, fn, unshift) {
     options = {};
   }
 
+  if (typeof fn !== 'function') {
+    throw new Error('post() requires a function, got "' + typeof fn + '"');
+  }
+
   if (unshift) {
     hooks.unshift(Object.assign({}, options, { fn: fn }));
   } else {

diff --git a/test/post.test.js b/test/post.test.js
@@ -40,6 +40,10 @@ describe('execPost', function() {
     assert.equal(hooks._posts.get('cook')[0].bar, 'baz');
   });
 
+  it('throws error if no function', function() {
+    assert.throws(() => hooks.post('test'), /got "undefined"/);
+  });
+
   it('multiple posts', function(done) {
     hooks.post('cook', function(eggs, callback) {
       setTimeout(

diff --git a/test/pre.test.js b/test/pre.test.js
@@ -65,6 +65,10 @@ describe('execPre', function() {
     assert.strictEqual(hooks._pres.get('cook')[1].fn, f1);
   });
 
+  it('throws error if no function', function() {
+    assert.throws(() => hooks.pre('test'), /got "undefined"/);
+  });
+
   it('arbitrary options', function() {
     const f1 = function() {};
     const f2 = function() {};